Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dart dependencies #1077

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Replace dart dependencies #1077

wants to merge 7 commits into from
+57 −96

Conversation

XavierPaquet-Rapold
Copy link
Contributor

⁉️ Related Issue

closes: #1072

📖 Description

  • Replace enum_to_string with native methods
  • Replace lint with flutter_lints
  • Remove flutter_config

🧪 How Has This Been Tested?

  • Run unit tests
  • Run app

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.

🖼️ Screenshots (if useful):

@XavierPaquet-Rapold XavierPaquet-Rapold requested a review from a team as a code owner November 2, 2024 02:08
EffBureau
EffBureau previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@EffBureau EffBureau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤓

@XavierPaquet-Rapold XavierPaquet-Rapold marked this pull request as draft November 8, 2024 15:06
@XavierPaquet-Rapold XavierPaquet-Rapold force-pushed the feature/1072-replace-dart-dependencies branch from d4651af to 4bd2d35 Compare November 9, 2024 01:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EffBureau EffBureau EffBureau left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
size: M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace and remove some dart dependencies
2 participants
@XavierPaquet-Rapold @EffBureau